Skip to content

New Bit column type added #6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

New Bit column type added #6938

wants to merge 1 commit into from

Conversation

@MalloD12
Copy link
Collaborator

@MalloD12 MalloD12 commented May 8, 2025 •
edited
Loading

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Will fixes #4677

  • New BitType class added.
  • Bit handling support added.
  • Test updates.

Things to be aware of

Things to worry about

Additional Context

@MalloD12
- New BitType class added.
094f330 
- Bit handling support added.
- Test updates.
@MalloD12 MalloD12 self-assigned this May 8, 2025
@MalloD12 MalloD12 mentioned this pull request May 8, 2025
Open
2 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems May 8, 2025
View reviewed changes
liquibase-standard/src/main/java/liquibase/datatype/core/BitType.java

@Override
public DatabaseDataType toDatabaseDataType(Database database) {
String originalDefinition = StringUtil.trimToEmpty(getRawDefinition());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
StringUtil.trimToEmpty
Loading
should be avoided because it has been deprecated.

Copilot Autofix

AI 6 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

liquibase-standard/src/main/java/liquibase/datatype/core/BitType.java
}
}

if ((database instanceof Db2zDatabase)) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 7 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.

Copilot Autofix

AI 6 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@mariochampion mariochampion moved this from New to Candidate in Liquibase Community May 13, 2025
@mariochampion mariochampion moved this from Candidate to Planned in Liquibase Community May 23, 2025
@MalloD12 MalloD12 moved this from Planned to Foundation Team Tickets in Liquibase Community Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filipelautert filipelautert Awaiting requested review from filipelautert filipelautert will be requested when the pull request is marked ready for review filipelautert is a code owner

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800 wwillard7800 will be requested when the pull request is marked ready for review wwillard7800 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@MalloD12 MalloD12

Labels

TypeBug

Projects

Liquibase Community
Status: Foundation Team Tickets

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PostgreSQL: column is of type bit but default expression is of type boolean

2 participants

@MalloD12