gh-6820 Fix metadata queries returning null in Azure SQL Managed Instances. #6902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sresnik-radicle
had a problem deploying
to
external
GitHub Actions
Failure
sresnik-radicle
had a problem deploying
to
external
GitHub Actions
Failure
|
I would appreciate a little guidance on any tests that should be added for this change. |
2 tasks
@MalloD12 could you suggest some tests here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
This is a fix for #6820 . In the metadata queries for the
DATABASECHANGELOGtable, the db_id is passed in as a parameter to theobject_nameandobject_schema_namefunctions in the query for table meta data, and column meta data. This results in an empty result set, and a failure when executing Liquibase.Things to be aware of
N/A
Things to worry about
N/A
Additional Context
This issue was discovered by running against the
masterdatabase on an Azure SQL Managed Instance more than once. The first time, theDATABASECHANGELOGtable is created correctly, subsequent runs fail when Liquibase tries to create the table again.