separate kernel series hashing#4194
Conversation
|
I rather Iike this idea. I have an idea to take it one step further, what do you think? Move all of the common files into Two other things:
|
ChrisIgel
force-pushed
the
kernel-hash-fix
branch
from
34f465b to
8243c34
Compare
|
I signed the commits, moved alls shared files to a I also tested various commands including updating the kernel hashes and to me it looked good. |
|
This is nice. I expect CI will fail on the hashes, but let's let it run and see what it says. |
|
Yup, it is the kernel dependencies. I will have to tag them just right |
|
OK, I copied those two tags. Take a look at the failed test, you need to update the hashes per the report. |
Signed-off-by: Chris Irrgang <chris.irrgang@gmx.de>
- add bsd/gnu cross compatibility for sed - also replace in */test.sh files - replace potentially problematic xargs - remove potentially problematic word boundary \b Signed-off-by: Chris Irrgang <chris.irrgang@gmx.de>
Signed-off-by: Chris Irrgang <chris.irrgang@gmx.de>
Signed-off-by: Chris Irrgang <chris.irrgang@gmx.de>
ChrisIgel
force-pushed
the
kernel-hash-fix
branch
from
c4932f4 to
b6497fc
Compare
|
Okay just running |
|
Why is it trying to build kernels? Makes no sense, as they already are out there. I will cancel that job and see what we missed. |
|
Well the hashes changed, that should be the reason right? |
yeah, but I added tags for the new ones, so let's check. If we wait for builds here, it will be forever |
|
I think that the Actually, that looks right, but I can pull down the manifest for it, so something is strange. |
|
Oh! I didn't tag the other images (debug, etc.). I can fix that. |
|
Pushed out. Let's see. |
|
This time it was happy. |
|
Thanks!! |
2 participants
@deitch What do you think about this solution?
- What I did
Added per-series kernel hashing and switched builds/tags/pushes to use the series-specific hash
- How I did it
SHARED_HASHfrom common build filesseries_hash(...) = hash(SHARED_HASH + series folder) + DIRTYfunctionseries_hash()in linuxkit build/show-tag/cache/push and tool targets- How to verify it
make listshows "Shared hash: "make show-tag-6.12.xprints baseimage-- Description for the changelog
Use per-series kernel hashes by combining a shared-files hash with the series folder