Looks like if I wanted to implement a hashtag override, Id want to define a HASHTAG that can matches the value of {{.Hash}} that is used in --tag.

This would allow me to override with while making changes so I dont end up invalidating the cache and then when the build work clear the linuxkit cache and not over ride.
make build-6.6.x HASHTAG=add_zfs

Looks like that requires this to be implemented in the makefile to do so.

// construct <ls-tree>-dirty-<content hash> tag
pkgHash += fmt.Sprintf("-dirty-%s", contentHash[0:7])

...

func (g git) contentHash() (string, error) {
	hash := sha256.New()
	// list of files tracked by git that might have changed
	trackedFiles, err := g.commandStdout(nil, "ls-files")
	if err != nil {
		return "", err
	}
	untrackedFiles, err := g.commandStdout(nil, "ls-files", "--exclude-standard", "--others")
	if err != nil {
		return "", err
	}
	allFiles := strings.Join([]string{trackedFiles, untrackedFiles}, "\n")
	scanner := bufio.NewScanner(strings.NewReader(strings.TrimSpace(allFiles)))
	for scanner.Scan() {
		filename := filepath.Join(g.dir, scanner.Text())
		info, err := os.Lstat(filename)
		if err != nil {
			log.Debugf("cannot stat %s: %s, skipped", filename, err)
			continue
		}
		if info.IsDir() || info.Mode()&os.ModeSymlink != 0 {
			// we do not want to calculate hash of directory or symlinks
			continue
		}
		f, err := os.Open(filename)
		if err != nil {
			log.Debugf("cannot open %s: %s, skipped", filename, err)
			continue
		}
		if _, err := io.Copy(hash, f); err != nil {
			_ = f.Close()
			return "", err
		}
		if err = f.Close(); err != nil {
			return "", err
		}
	}
	if err = scanner.Err(); err != nil {
		return "", err
	}
	return fmt.Sprintf("%x", hash.Sum(nil)), nil
}

Reuse cached images while dirty #4122

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions