Skip to content

Fix warnings: -Wsubobject-linkage & -Wreturn-type #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctrlcctrlv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix warnings: -Wsubobject-linkage & -Wreturn-type #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/linuxdeploy/subprocess/pipe_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class pipe_reader {
SUCCESS = 0,
TIMEOUT,
END_OF_FILE,
RUNTIME_ERROR
};

/**
Expand Down
3 changes: 2 additions & 1 deletion src/core/appdir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ using namespace cimg_library;

namespace fs = std::filesystem;

namespace {
namespace private_items {
Copy link
Copy Markdown
Member

@TheAssassin TheAssassin Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes no sense in this context. I need to think about this...

// equivalent to 0644
constexpr fs::perms DEFAULT_PERMS = fs::perms::owner_write | fs::perms::owner_read | fs::perms::group_read | fs::perms::others_read;
// equivalent to 0755
Expand Down Expand Up @@ -97,6 +97,7 @@ namespace {
namespace linuxdeploy {
namespace core {
namespace appdir {
using namespace private_items;
class AppDir::PrivateData {
public:
fs::path appDirPath;
Expand Down
1 change: 1 addition & 0 deletions src/subprocess/pipe_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,5 @@ pipe_reader::result pipe_reader::read(std::vector<std::string::value_type>& buff
// this is a should-never-ever-happen case, a return value not handled by the lines above is actually not possible
throw std::runtime_error{"unexpected return value from pollfd"};
}
return result::RUNTIME_ERROR;
}