CI: upgrade to checkout v4, upload-artifact 4, setup-go v5, Go 1.21#95
Merged
orangecms merged 2 commits intolinuxboot:mainfrom Sep 21, 2024
Merged
CI: upgrade to checkout v4, upload-artifact 4, setup-go v5, Go 1.21#95orangecms merged 2 commits intolinuxboot:mainfrom
orangecms merged 2 commits intolinuxboot:mainfrom
Conversation
Contributor
Author
|
All the go install commands need fixing, too. |
orangecms
force-pushed
the
ci-maintenance
branch
4 times, most recently
from
6252a9b to
55d7726
Compare
Contributor
Author
|
The Makefiles are quite messy. I propose splitting them into four parts:
There are lots of tight coupling though, e.g. the initramfs file name in the kernel config has to match up with the u-root build step. |
Keeping actions on a recent version is necessary because older ones are deprecated over time and would at some point error. We have seen such errors already, so this upgrades all actions. Also drop the GO111MODULE env var. Go has changed. Signed-off-by: Daniel Maslowski <info@orangecms.org>
orangecms
force-pushed
the
ci-maintenance
branch
from
ed7b488 to
530c4fd
Compare
Rework the entire Makefile. The go install commands have changed. For cpu, u-root now requires explicit Go workspace setups. Elvish was dropped in favor of gosh. The other Makefiles will also need fixing. This one is the first running on CI, so start with it. Signed-off-by: Daniel Maslowski <info@orangecms.org>
orangecms
force-pushed
the
ci-maintenance
branch
from
530c4fd to
7bd7842
Compare
rminnich
approved these changes
Sep 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping actions on a recent version is necessary because older ones are deprecated over time and would at some point error. We have seen such errors already, so this upgrades all actions.
resolves #94