6.19: reset QuickSPI touch IC on resume to fix dead touchscreen after s2idle (Surface Pro 10)#2163
Open
d3z-the-dev wants to merge 1 commit into
Open
Conversation
SP10 exposes only [s2idle] (no deep/S3); the touch IC loses power across it, so quickspi_resume() must re-enumerate like quickspi_restore() does, gated on !device_may_wakeup(). Tested on a Surface Pro 10. Link: linux-surface#1799
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the touchscreen dying after suspend/resume on the Surface Pro 10
(Intel Core Ultra 7 / Meteor Lake), reported in #1799.
Why
The SP10 only suspends through s2idle -
cat /sys/power/mem_sleepshows[s2idle], there is nodeep/S3 entry at all. The QuickSPI touch IC losespower across that s2idle suspend (like across hibernation), but
quickspi_resume()only sendsHIDSPI_ON, so the descriptor read fails(
recv failed: -11) and touch stays dead until reboot.Fix
Make
quickspi_resume()run the samereset_tic()re-enumeration thatquickspi_restore()already does, but only whendevice_may_wakeup() == false.Keying off retained power (not suspend type) is what makes it work on this
s2idle-only machine, where any
PM_SUSPEND_MEM/S3 check never fires.Testing
Built 6.19 with this patch, installed on a Surface Pro 10, many s2idle
suspend/resume cycles - touchscreen keeps working.
Notes
Equivalent fix posted upstream on linux-input (based on v7.1), under review with
the Intel maintainer, not yet merged. This is the 6.19 backport.
Thread: https://lore.kernel.org/linux-input/20260529222210.1532876-1-d3z.the.dev@gmail.com/
Closes #1799