Add patches for 7.0 by Apiznel · Pull Request #2079 · linux-surface/linux-surface

Apiznel · 2026-04-26T20:26:57Z

Changed 0x10 to 0x11 in 0013-cameras.patch as suggested here: #2057

Derived from latest 6.19 patches

Experimental camera support for the Surface Pro 9. Link: linux-surface/linux-surface#1867 Patchset: cameras [ Mingcong Bai: Since commit 2a7b765 ("platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)") took the 0x10 entry used by the original patch for Surface Pro 9's secondary power rail, change the latter to 0x11 to adapt to this change. Link: linux-surface/linux-surface#2057 Link: linux-surface/linux-surface#2079 ] Link: https://github.com/linux-surface/linux-surface/tree/4c136ec928ce0b458562c7533852db67a8e0dc91 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>

Changes: - Rebase onto v7.0.5

Apiznel · 2026-05-08T14:41:54Z

Rebased for: gregkh/linux@9c58e98

hedmo · 2026-05-09T05:30:22Z

no issues from my side (SB3).

Experimental camera support for the Surface Pro 9. Link: linux-surface/linux-surface#1867 Patchset: cameras [ Mingcong Bai: Since commit 2a7b765 ("platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)") took the 0x10 entry used by the original patch for Surface Pro 9's secondary power rail, change the latter to 0x11 to adapt to this change. Link: linux-surface/linux-surface#2057 Link: linux-surface/linux-surface#2079 ] Link: https://github.com/linux-surface/linux-surface/tree/4c136ec928ce0b458562c7533852db67a8e0dc91 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>

orthogonaleety · 2026-05-22T08:56:06Z

27577cd & f4fd358 good for me for F43 (not signed), with kernel 7.0.7, installed against Fedora 43, Surface Pro 8
run https://github.com/orthogonaleety/linux-surface/actions/runs/26240487204
built with https://github.com/orthogonaleety/linux-surface/commits/f43-7-0-x
(Can't comment on #2079 (comment) as don't use IPU6 cameras )

Experimental camera support for the Surface Pro 9. Link: linux-surface/linux-surface#1867 Patchset: cameras [ Mingcong Bai: Since commit 2a7b765 ("platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)") took the 0x10 entry used by the original patch for Surface Pro 9's secondary power rail, change the latter to 0x11 to adapt to this change. Link: linux-surface/linux-surface#2057 Link: linux-surface/linux-surface#2079 ] Link: https://github.com/linux-surface/linux-surface/tree/4c136ec928ce0b458562c7533852db67a8e0dc91 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>

cfouche3005 · 2026-05-26T07:09:17Z

Regression on Surface Book 1, no touchscreen (tested on NixOS via this PR) on kernel 7.0.9

orthogonaleety · 2026-05-26T07:37:08Z

Regression on Surface Book 1, no touchscreen (tested on NixOS via this PR) on kernel 7.0.9

Hi @cfouche3005

Are you running NixOS stable or unstable?

Prior to using this PR:

What libwacom 'were' you using? libwacom-surface or libwacom (standard) ?
Which of those libwacom do you see in place now?
What Libwacom (standard) version would your NixOS be packaging if you were on standard kernel?

NixOS packages unstable lists libwacom 2.18. libwacom-surface is 2.17. So its plasuible libwacom-surface has been replaced, by libwacom standard (such as happens with Fedora upgrade 43 > 44) , and you will find downgrading to libwacom-surface 2.17 is not an option either.

i.e this matters because in that case the issue is not this PR per-say

cfouche3005 · 2026-05-26T07:49:45Z

I am on full unstable
I use libwacom-surface from Nixos Unstable (installed explicitly via Nix) and there is only libwacom surface installed

The weird thing is that I use two surface device with the same flake config and flake.lock (so same version of packages and dependencies) and only the surface book touchscreen doesn't work (the surface laptop studio touchscreen work perfectly).
Also, when checking the log I see kernel error related to the screen (no libwacom error)

orthogonaleety · 2026-05-26T08:12:59Z

Thanks cfouche. In that case I doubt its relevant. No low hanging fruit here then probably. And I should step back because I'm just complicating the PR discussion now.
However, an aside, and it might be just that I'm not understanding how Nixos package pages can be put together, but the source link for NixOS packages for libwacom-surface, actually just links back to the source for just standard libwacom. (it does that under both 25.11 and unstable). https://search.nixos.org/packages?channel=unstable&query=libwacom-surface > https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/li/libwacom/package.nix#L86

cfouche3005 · 2026-05-26T08:22:47Z

The link is kind of wrong (but not totally), the package is declared here but as the libwacom-surface use the libwacom build declaration, it links to the libwacom package

orthogonaleety · 2026-05-26T08:35:59Z

Maybe raise that libwacom-surface discrepancy with the NixOS package maintainersas an aside.
You also said

Also, when checking the log I see kernel error related to the screen_

Maybe raise an issue with full details. Not sure how much traction it will get as all this is kind of 'ahead' of linux-surface right now but, I guess its up to who wants to engage and how much. It might help to get news ahead of time. I think there comes a point where one has to say 'ok, the only change was surface 6.x to surface 7.x, but what exactly is is broken where, so it can be fixed'

cfouche3005 · 2026-05-26T08:52:11Z

I will open an issue this evening as I don't have my surface book to get the full logs but from what I have seen, it seem the issue come from the ipts kernel driver

Experimental camera support for the Surface Pro 9. Link: linux-surface/linux-surface#1867 Patchset: cameras [ Mingcong Bai: Since commit 2a7b765 ("platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)") took the 0x10 entry used by the original patch for Surface Pro 9's secondary power rail, change the latter to 0x11 to adapt to this change. Link: linux-surface/linux-surface#2057 Link: linux-surface/linux-surface#2079 ] Link: https://github.com/linux-surface/linux-surface/tree/4c136ec928ce0b458562c7533852db67a8e0dc91 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>

orthogonaleety · 2026-06-03T21:50:31Z

Hi @Apiznel
Sorry to further inflate this PR discussion but I'm not sure what best to do with the following. cfouche's issue has turned out to be a some time standing bug in ipts implemented in the 005 patch file.
The details are in my comment. #2150 (comment)
with my version of a fix near the bottom of that comment
https://github.com/user-attachments/files/28481922/0017-ipts-fix-hid-report-data-size.patch
cfouche has confirmed it tests good here #2150 (comment)

There is also a more succinct commit/PR type description of the matter in an issue I subsequently logged against ipts linux-surface/intel-precise-touch#34 That might be the best think to read first.

If linux-surface had a test branch I would be happy to commend a PR to that, but I'm not a developer, nor experienced in linux kernel concerns at that level, so on principle I'm not happy to risk someone overly assuming something is ready for master (production).

I note you are a past accepted contributor and your work in these commits.
Perhaps you or someone here could examine it, consider where it may perhaps need to be implemented differently or not, and create a commit over the 005 patch file and PR accordingly.

Many thanks.

cfouche3005 · 2026-06-03T22:01:05Z

To add I only tested it on the surface book 1, I don't know if this patch break other surface devices

dotlambda

The file configs/surface-7.0.config is missing.

Based on the current v6.19 config

Apiznel · 2026-06-04T00:58:02Z

@orthogonaleety I probably have as much experience as you do in the matter 😅. This would be better reviewed by @StollD. I'm just a contributor who occasionally rebases the patches as needed (it's nothing complicated). I do appreciate your effort in resolving the issue though.

Apiznel · 2026-06-04T00:58:37Z

The file configs/surface-7.0.config is missing.

@dotlambda Added. Thanks!

Experimental camera support for the Surface Pro 9. Link: linux-surface/linux-surface#1867 Patchset: cameras [ Mingcong Bai: Since commit 2a7b765 ("platform/x86: int3472: Handle GPIO type 0x10 (DOVDD)") took the 0x10 entry used by the original patch for Surface Pro 9's secondary power rail, change the latter to 0x11 to adapt to this change. Link: linux-surface/linux-surface#2057 Link: linux-surface/linux-surface#2079 ] Link: https://github.com/linux-surface/linux-surface/tree/4c136ec928ce0b458562c7533852db67a8e0dc91 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>

Add patches for 7.0

27577cd

Derived from latest 6.19 patches

Apiznel added 2 commits May 8, 2026 14:12

Merge branch 'linux-surface:master' into master

4b5ab30

Update v7.0 patches

d9173b9

Changes: - Rebase onto v7.0.5

Merge branch 'linux-surface:master' into master

172547d

8bitbuddhist mentioned this pull request May 17, 2026

microsoft/surface: kernel 7.0 NixOS/nixos-hardware#1870

Draft

2 tasks

cfouche3005 mentioned this pull request May 27, 2026

No touchscreen on 7.0.X on Surface book 1 #2150

Open

dotlambda reviewed Jun 4, 2026

View reviewed changes

Add config for v7.0

6dc9bc6

Based on the current v6.19 config

Uh oh!

Conversation

Apiznel commented Apr 26, 2026

Uh oh!

Apiznel commented May 8, 2026

Uh oh!

hedmo commented May 9, 2026

Uh oh!

orthogonaleety commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfouche3005 commented May 26, 2026

Uh oh!

orthogonaleety commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfouche3005 commented May 26, 2026

Uh oh!

orthogonaleety commented May 26, 2026

Uh oh!

cfouche3005 commented May 26, 2026

Uh oh!

orthogonaleety commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfouche3005 commented May 26, 2026

Uh oh!

orthogonaleety commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfouche3005 commented Jun 3, 2026

Uh oh!

dotlambda left a comment

Choose a reason for hiding this comment

Uh oh!

Apiznel commented Jun 4, 2026

Uh oh!

Apiznel commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

orthogonaleety commented May 22, 2026 •

edited

Loading

orthogonaleety commented May 26, 2026 •

edited

Loading

orthogonaleety commented May 26, 2026 •

edited

Loading

orthogonaleety commented Jun 3, 2026 •

edited

Loading