Linodes and OBJ Integration Tests Improvements - #434
Merged
lgarber-akamai merged 3 commits intoJul 10, 2024
Merged
Conversation
zliang-akamai
requested review from
jriddle-linode,
lgarber-akamai and
ykim-akamai
and removed request for
a team
July 10, 2024 06:45
ezilber-akamai
self-requested a review
July 10, 2024 13:29
lgarber-akamai
approved these changes
Jul 10, 2024
lgarber-akamai
left a comment
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Changes look good and all tests are passing on my end, nice work!
ezilber-akamai
approved these changes
Jul 10, 2024
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests passing locally!
zliang-akamai
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
To increase test code readability and reliability.
✔️ How to Test
Full integration tests suite run: https://github.com/linode/linode_api4-python/actions/runs/9869998519 (may contains other unfixed failures)