test: Add error handling in e2e_cloud_firewall fixture - #431
Merged
ykim-akamai merged 3 commits intoJul 2, 2024
Merged
Conversation
ykim-akamai
requested review from
ezilber-akamai and
zliang-akamai
and removed request for
a team
July 2, 2024 19:50
ezilber-akamai
approved these changes
Jul 2, 2024
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests passing locally. Nice work!
zliang-akamai
approved these changes
Jul 2, 2024
Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Tests will fail due to ConnectionError at rare occasion as seen in here.
This PR adds a retry mechanism with error handling in the e2e_cloud_firewall fixture for more reliable test runs
✔️ How to Test
test testint, or any test case📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.