test: Add missing integration tests to improve coverage for identified gaps - #429
Merged
ykim-akamai merged 5 commits intoJul 7, 2024
Merged
Conversation
ykim-akamai
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team
June 27, 2024 01:34
ykim-akamai
marked this pull request as draft
June 27, 2024 01:34
ykim-akamai
changed the title
ykim-akamai
marked this pull request as ready for review
June 27, 2024 16:39
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
test_get_current_longview_plan is failing locally for me with the following error:
test_linode_client = <linode_api4.linode_client.LinodeClient object at 0x10554cda0>
def test_get_current_longview_plan(test_linode_client):
lv_plan = test_linode_client.load(LongviewPlan, "")
> assert "Longview" in lv_plan.label
E TypeError: argument of type 'NoneType' is not iterable
test/integration/models/longview/test_longview.py:58: TypeError
=========================================================================== short test summary info ===========================================================================
FAILED test/integration/models/longview/test_longview.py::test_get_current_longview_plan - TypeError: argument of type 'NoneType' is not iterable
After I changed my Longview plan from Longview Free to Longview Pro 3 pack, it passed. Is this the intended behavior?
Contributor
Author
Good catch, looks like Longview free plan actually does not return anything and update using |
…nto test/fill_test_gaps_in_models
ezilber-akamai
approved these changes
Jun 28, 2024
yec-akamai
approved these changes
Jul 5, 2024
yec-akamai
left a comment
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests passed locally, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Filling in identified test gaps found in spike - TPT-2699. Integration Tests have been added to following test suites:
For more details refer to spreadsheet attached in TPT-3010
✔️ How to Test
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.