Update OBJ Group and Objects for MultiCluster Object Storage API Changes - #426
Merged
zliang-akamai merged 7 commits intoJul 2, 2024
Conversation
…`DeprecationWarning`
zliang-akamai
marked this pull request as ready for review
June 21, 2024 06:20
zliang-akamai
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
June 21, 2024 06:20
lgarber-akamai
approved these changes
Jun 27, 2024
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests are passing on my end and I haven't run into any more issues when testing against this from Ansible. Excellent work!
yec-akamai
approved these changes
Jul 1, 2024
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Everything works locally, nice work!
| properties = { | ||
| "cluster": Property(identifier=True), | ||
| "region": Property(identifier=True), | ||
| "cluster": Property(), |
Contributor
There was a problem hiding this comment.
Should we add a deprecated note to the cluster property as well?
Member
Author
There was a problem hiding this comment.
Thanks for the head up! I think there isn't a clear way to mark it as deprecated in Python since the property is in a dict... Let me think about it maybe we can modify Property class to accept a deprecation flag. I can do that in a future PR, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to modify
ObjectStorageGroupand object storage related SDK objects to adapt to the MultiCluster Object Storage API changes.✔️ How to Test
Automated Testing
Manual Testing