Skip to content

Using api_endpoint as the URL Path for Methods in ObjectStorageBucket - #421

Merged
zliang-akamai merged 2 commits into
linode:devfrom
zliang-akamai:zhiwei/obj-bucket-use-endpoint-attr
Jun 18, 2024
Merged

Using api_endpoint as the URL Path for Methods in ObjectStorageBucket#421
zliang-akamai merged 2 commits into
linode:devfrom
zliang-akamai:zhiwei/obj-bucket-use-endpoint-attr

Conversation

@zliang-akamai

@zliang-akamai zliang-akamai commented Jun 17, 2024

Copy link
Copy Markdown
Member

📝 Description

Following the pattern in other classes, using api_endpoint as the API path.

✔️ How to Test

make testunit
import os

from linode_api4 import LinodeClient
from linode_api4.objects import ObjectStorageACL

client = LinodeClient(os.getenv("LINODE_TOKEN"))


bucket1 = client.object_storage.bucket_create(
    "us-mia-1",
    "test-python-sdk-bucket",
    ObjectStorageACL.PRIVATE,
)

print(bucket1._raw_json)

bucket1.access_modify(ObjectStorageACL.PRIVATE, False)
bucket1.access_update(ObjectStorageACL.PRIVATE, False)
print(bucket1.contents())
print(bucket1.ssl_cert().dict)
bucket1.ssl_cert_delete()
bucket1._api_get()

print(bucket1._raw_json)
bucket1.delete()

@zliang-akamai
zliang-akamai requested a review from a team as a code owner June 17, 2024 23:48
@zliang-akamai
zliang-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team June 17, 2024 23:48

@lgarber-akamai lgarber-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yec-akamai yec-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zliang-akamai
zliang-akamai merged commit 77e3a84 into linode:dev Jun 18, 2024
@zliang-akamai zliang-akamai added the improvement for improvements in existing functionality in the changelog. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants