Cleanup docs, add type annotations, improved class ref - #419
Merged
Conversation
zliang-akamai
requested review from
lgarber-akamai and
ykim-akamai
and removed request for
a team
June 14, 2024 15:23
zliang-akamai
force-pushed
the
zhiwei/cleanup-obj
branch
from
June 14, 2024 15:27
6f0ceb4 to
987536b
Compare
lgarber-akamai
approved these changes
Jun 17, 2024
lgarber-akamai
left a comment
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Always good to reduce tech debt, nice work!
zliang-akamai
added
the
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
type(self)to better support class inheritance.✔️ How to Test
make testunitmake testint