Skip to content

test: Address flaky tests in linode_client and lke #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ykim-akamai merged 4 commits into from
Jun 4, 2024
Merged

test: Address flaky tests in linode_client and lke #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
795621e
unskip lke test, update test_lke_node_recycle, filter swap disk for i…
ykim-akamai Jun 4, 2024
9aed63c
skip pc account test
ykim-akamai Jun 4, 2024
0f6385d
remove comment
ykim-akamai Jun 4, 2024
de54875
update with cleaner syntax
ykim-akamai Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/integration/linode_client/test_linode_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ def test_image_create(setup_client_and_linode):

label = get_test_label()
description = "Test description"
disk_id = linode.disks.first().id
usable_disk = [v for v in linode.disks if v.filesystem != "swap"]

image = client.image_create(
disk=disk_id, label=label, description=description
disk=usable_disk[0].id, label=label, description=description
)

assert image.label == label
Expand Down
1 change: 1 addition & 0 deletions test/integration/models/account/test_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def test_get_user(test_linode_client):


def test_list_child_accounts(test_linode_client):
pytest.skip("Configure test account settings for Parent child")
client = test_linode_client
child_accounts = client.account.child_accounts()
if len(child_accounts) > 0:
Expand Down
12 changes: 6 additions & 6 deletions test/integration/models/lke/test_lke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@ def test_get_lke_clusters(test_linode_client, lke_cluster):


def test_get_lke_pool(test_linode_client, lke_cluster):
pytest.skip("TPT-2511")
cluster = lke_cluster

pool = test_linode_client.load(LKENodePool, cluster.pools[0].id, cluster.id)

assert cluster.pools[0]._raw_json == pool
assert cluster.pools[0].id == pool.id


def test_cluster_dashboard_url_view(lke_cluster):
Expand Down Expand Up @@ -147,10 +146,11 @@ def test_lke_node_recycle(test_linode_client, lke_cluster):
"ready",
)

node_pool = test_linode_client.load(
LKENodePool, cluster.pools[0].id, cluster.id
)
node = node_pool.nodes[0]
# Reload cluster
cluster = test_linode_client.load(LKECluster, lke_cluster.id)

node = cluster.pools[0].nodes[0]

assert node.status == "ready"


Expand Down