Skip to content

test: Add Linode Cloud Firewall for integration tests #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ykim-akamai merged 5 commits into from
Jun 12, 2024
Merged

test: Add Linode Cloud Firewall for integration tests #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a38d727
add cloud firewall to integration tests
ykim-akamai May 27, 2024
d8135e9
Merge branch 'dev' into test/add_linode_cloud_firewall
ykim-akamai May 27, 2024
f7f0142
pr comments
ykim-akamai Jun 4, 2024
434de83
update fixture name
ykim-akamai Jun 4, 2024
073b6ff
lint
ykim-akamai Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 91 additions & 6 deletions test/integration/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import ipaddress
import os
import random
import time
from typing import Set

import pytest
import requests

from linode_api4 import ApiError
from linode_api4.linode_client import LinodeClient
Expand Down Expand Up @@ -50,16 +52,90 @@ def run_long_tests():
return os.environ.get(RUN_LONG_TESTS, None)


@pytest.fixture(autouse=True, scope="session")
def e2e_test_firewall(test_linode_client):
def is_valid_ipv4(address):
try:
ipaddress.IPv4Address(address)
return True
except ipaddress.AddressValueError:
return False

def is_valid_ipv6(address):
try:
ipaddress.IPv6Address(address)
return True
except ipaddress.AddressValueError:
return False

def get_public_ip(ip_version="ipv4"):
url = (
f"https://api64.ipify.org?format=json"
if ip_version == "ipv6"
else f"https://api.ipify.org?format=json"
)
response = requests.get(url)
return str(response.json()["ip"])

def create_inbound_rule(ipv4_address, ipv6_address):
rule = [
{
"protocol": "TCP",
"ports": "22",
"addresses": {},
"action": "ACCEPT",
}
]
if is_valid_ipv4(ipv4_address):
rule[0]["addresses"]["ipv4"] = [f"{ipv4_address}/32"]

if is_valid_ipv6(ipv6_address):
rule[0]["addresses"]["ipv6"] = [f"{ipv6_address}/128"]

return rule

# Fetch the public IP addresses

ipv4_address = get_public_ip("ipv4")
ipv6_address = get_public_ip("ipv6")

inbound_rule = create_inbound_rule(ipv4_address, ipv6_address)

client = test_linode_client

rules = {
"outbound": [],
"outbound_policy": "ACCEPT",
"inbound": inbound_rule,
"inbound_policy": "DROP",
}

label = "cloud_firewall_" + str(int(time.time()))

firewall = client.networking.firewall_create(
label=label, rules=rules, status="enabled"
)

yield firewall

firewall.delete()


@pytest.fixture(scope="session")
def create_linode(test_linode_client):
def create_linode(test_linode_client, e2e_test_firewall):
client = test_linode_client

available_regions = client.regions()
chosen_region = available_regions[4]
timestamp = str(time.time_ns())
label = "TestSDK-" + timestamp

linode_instance, password = client.linode.instance_create(
"g6-nanode-1", chosen_region, image="linode/debian10", label=label
"g6-nanode-1",
chosen_region,
image="linode/debian12",
label=label,
firewall=e2e_test_firewall,
)

yield linode_instance
Expand All @@ -68,15 +144,20 @@ def create_linode(test_linode_client):


@pytest.fixture
def create_linode_for_pass_reset(test_linode_client):
def create_linode_for_pass_reset(test_linode_client, e2e_test_firewall):
client = test_linode_client

available_regions = client.regions()
chosen_region = available_regions[4]
timestamp = str(time.time_ns())
label = "TestSDK-" + timestamp

linode_instance, password = client.linode.instance_create(
"g6-nanode-1", chosen_region, image="linode/debian10", label=label
"g6-nanode-1",
chosen_region,
image="linode/debian10",
label=label,
firewall=e2e_test_firewall,
)

yield linode_instance, password
Expand Down Expand Up @@ -303,15 +384,19 @@ def create_vpc_with_subnet(test_linode_client, create_vpc):

@pytest.fixture(scope="session")
def create_vpc_with_subnet_and_linode(
test_linode_client, create_vpc_with_subnet
test_linode_client, create_vpc_with_subnet, e2e_test_firewall
):
vpc, subnet = create_vpc_with_subnet

timestamp = str(int(time.time()))
label = "TestSDK-" + timestamp

instance, password = test_linode_client.linode.instance_create(
"g6-standard-1", vpc.region, image="linode/debian11", label=label
"g6-standard-1",
vpc.region,
image="linode/debian11",
label=label,
firewall=e2e_test_firewall,
)

yield vpc, subnet, instance, password
Expand Down
10 changes: 7 additions & 3 deletions test/integration/linode_client/test_linode_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,19 @@
from linode_api4.objects import ConfigInterface, ObjectStorageKeys, Region


@pytest.fixture(scope="session", autouse=True)
def setup_client_and_linode(test_linode_client):
@pytest.fixture(scope="session")
def setup_client_and_linode(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4] # us-ord (Chicago)
label = get_test_label()

linode_instance, password = client.linode.instance_create(
"g6-nanode-1", chosen_region, image="linode/debian10", label=label
"g6-nanode-1",
chosen_region,
image="linode/debian10",
label=label,
firewall=e2e_test_firewall,
)

yield client, linode_instance
Expand Down
17 changes: 11 additions & 6 deletions test/integration/models/linode/test_linode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def linode_with_volume_firewall(test_linode_client):
"outbound": [],
"outbound_policy": "DROP",
"inbound": [],
"inbound_policy": "ACCEPT",
"inbound_policy": "DROP",
}

linode_instance, password = client.linode.instance_create(
Expand Down Expand Up @@ -69,15 +69,19 @@ def linode_with_volume_firewall(test_linode_client):


@pytest.fixture(scope="session")
def linode_for_network_interface_tests(test_linode_client):
def linode_for_network_interface_tests(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4]
timestamp = str(time.time_ns())
label = "TestSDK-" + timestamp

linode_instance, password = client.linode.instance_create(
"g6-nanode-1", chosen_region, image="linode/debian10", label=label
"g6-nanode-1",
chosen_region,
image="linode/debian10",
label=label,
firewall=e2e_test_firewall,
)

yield linode_instance
Expand All @@ -86,7 +90,7 @@ def linode_for_network_interface_tests(test_linode_client):


@pytest.fixture
def linode_for_disk_tests(test_linode_client):
def linode_for_disk_tests(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4]
Expand All @@ -97,6 +101,7 @@ def linode_for_disk_tests(test_linode_client):
chosen_region,
image="linode/alpine3.19",
label=label + "_long_tests",
firewall=e2e_test_firewall,
)

# Provisioning time
Expand All @@ -119,7 +124,7 @@ def linode_for_disk_tests(test_linode_client):


@pytest.fixture
def create_linode_for_long_running_tests(test_linode_client):
def create_linode_for_long_running_tests(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4]
Expand All @@ -130,6 +135,7 @@ def create_linode_for_long_running_tests(test_linode_client):
chosen_region,
image="linode/debian10",
label=label + "_long_tests",
firewall=e2e_test_firewall,
)

yield linode_instance
Expand Down Expand Up @@ -412,7 +418,6 @@ def test_disk_resize_and_duplicate(test_linode_client, linode_for_disk_tests):
time.sleep(40)

wait_for_disk_status(dup_disk, 120)

assert dup_disk.linode_id == linode.id


Expand Down
9 changes: 6 additions & 3 deletions test/integration/models/nodebalancer/test_nodebalancer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@


@pytest.fixture(scope="session")
def linode_with_private_ip(test_linode_client):
def linode_with_private_ip(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4]
Expand All @@ -19,6 +19,7 @@ def linode_with_private_ip(test_linode_client):
image="linode/debian10",
label=label,
private_ip=True,
firewall=e2e_test_firewall,
)

yield linode_instance
Expand All @@ -27,13 +28,15 @@ def linode_with_private_ip(test_linode_client):


@pytest.fixture(scope="session")
def create_nb_config(test_linode_client):
def create_nb_config(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4]
label = "nodebalancer_test"

nb = client.nodebalancer_create(region=chosen_region, label=label)
nb = client.nodebalancer_create(
region=chosen_region, label=label, firewall=e2e_test_firewall.id
)

config = nb.config_create()

Expand Down
8 changes: 6 additions & 2 deletions test/integration/models/volume/test_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,19 @@


@pytest.fixture(scope="session")
def linode_for_volume(test_linode_client):
def linode_for_volume(test_linode_client, e2e_test_firewall):
client = test_linode_client
available_regions = client.regions()
chosen_region = available_regions[4]
timestamp = str(time.time_ns())
label = "TestSDK-" + timestamp

linode_instance, password = client.linode.instance_create(
"g6-nanode-1", chosen_region, image="linode/debian10", label=label
"g6-nanode-1",
chosen_region,
image="linode/debian10",
Comment thread
ykim-akamai marked this conversation as resolved.
label=label,
firewall=e2e_test_firewall,
)

yield linode_instance
Expand Down