Skip to content

test: Add Linode Cloud Firewall for integration tests - #408

Merged
ykim-akamai merged 5 commits into
linode:devfrom
ykim-akamai:test/add_linode_cloud_firewall
Jun 12, 2024
Merged

test: Add Linode Cloud Firewall for integration tests#408
ykim-akamai merged 5 commits into
linode:devfrom
ykim-akamai:test/add_linode_cloud_firewall

Conversation

@ykim-akamai

@ykim-akamai ykim-akamai commented May 27, 2024

Copy link
Copy Markdown
Contributor

📝 Description

This PR implements Linode Cloud Firewall for integration tests to enhance security.

  • Default Inbound policy: DROP
  • Default Outbound policy: ACCEPT
  • Inbound rule: inbound rule with public ip on port 22

Note: GHA does not support ipv6 so only ipv4 will get added in firewall during GHA execution. However, ipv6 will get added automatically if ipv6 address and route exist

✔️ How to Test

make test-int

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai
ykim-akamai requested a review from a team as a code owner May 27, 2024 18:12
@ykim-akamai
ykim-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team May 27, 2024 18:12
Comment thread test/integration/models/volume/test_volume.py
Comment thread test/integration/models/nodebalancer/test_nodebalancer.py Outdated
Comment thread test/integration/conftest.py Outdated
Comment thread test/integration/conftest.py Outdated

@jriddle-linode jriddle-linode left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works locally, just need to address @zliang-akamai feedback.

@ykim-akamai
ykim-akamai requested a review from zliang-akamai June 4, 2024 20:01

@zliang-akamai zliang-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jriddle-linode jriddle-linode added the testing for updates to the testing suite in the changelog. label Jun 12, 2024
@ykim-akamai
ykim-akamai merged commit 7ccc16c into linode:dev Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants