Skip to content

test: Fix failure in oauth test due to missing fixture initialization #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zliang-akamai merged 3 commits into from
May 28, 2024
Merged

test: Fix failure in oauth test due to missing fixture initialization #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bcb3eb
add login_client in Makefile and add initial fixture to oauth test
ykim-akamai May 21, 2024
4827708
lint
ykim-akamai May 21, 2024
5b95ea2
Merge branch 'dev' into test/fix_oauth_test_failure
ykim-akamai May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ endif

ifdef TEST_SUITE
ifneq ($(TEST_SUITE),linode_client)
TEST_COMMAND = models/$(TEST_SUITE)
ifneq ($(TEST_SUITE),login_client)
TEST_COMMAND = models/$(TEST_SUITE)
else
TEST_COMMAND = login_client
endif
else
TEST_COMMAND = linode_client
endif
Expand Down
4 changes: 3 additions & 1 deletion test/integration/login_client/test_login_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ def test_get_oauth_clients(
assert str(test_oauth_client_two.id) in id_list


def test_get_oauth_clients_dont_reveal_secret(test_linode_client):
def test_get_oauth_clients_dont_reveal_secret(
test_linode_client, test_oauth_client
):
oauth_client_secret = test_linode_client.account.oauth_clients()[0].secret

assert oauth_client_secret == "<REDACTED>"
Expand Down