test: Add new tests for Oauth and Login Client - #403
Merged
ykim-akamai merged 3 commits intoApr 26, 2024
Conversation
ykim-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
April 24, 2024 03:10
lgarber-akamai
approved these changes
Apr 24, 2024
lgarber-akamai
left a comment
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests are all passing on my end, great work!
jriddle-linode
approved these changes
Apr 25, 2024
jriddle-linode
left a comment
jriddle-linode
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, passing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding integration test coverage for Oauth and Login Clients
Note: These tests does not involve an actual oauth application as it adds lot more complexity. However I think Pytest Flask is a possible choice to automate everything involving an actual Oauth app which will be in a different PR.
✔️ How to Test
make INTEGRATION_TEST_PATH=login_client testint📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.