new: Add available field to AccountAvailability class - #395
Merged
Conversation
lgarber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
April 15, 2024 16:02
yec-akamai
approved these changes
Apr 15, 2024
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Everything works well on my end
ykim-akamai
approved these changes
Apr 16, 2024
ykim-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tests pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull requests adds the new
availablefield to theAccountAvailabilityclass and adjusts the unit tests/fixtures accordingly.✔️ How to Test
The following test steps assume you have pulled this PR locally and run
make install.Unit Testing
Manual Testing
NOTE: Ensure the
base_urlkwarg is updated to point at the correct API environment.