test: address intermittent test failures - #394
Merged
ykim-akamai merged 5 commits intoApr 16, 2024
Merged
Conversation
ykim-akamai
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
April 11, 2024 21:23
yec-akamai
reviewed
Apr 12, 2024
yec-akamai
left a comment
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
I'm getting some different errors on my local, maybe just related to my account limitation:
=========================== short test summary info ============================
FAILED test/integration/models/test_linode.py::test_linode_create_disk - linode_api4.errors.ApiError: 400: [size] You do not have enough unallocated...
FAILED test/integration/models/test_linode.py::TestNetworkInterface::test_delete_interface_containing_vpc - TimeoutError: Timeout Error: resource is not available in 60 seconds
============ 2 failed, 117 passed, 21 skipped in 2462.97s (0:41:02) ============
| return linode.status == status | ||
|
|
||
|
|
||
| def get_type(linode: Instance, type: str): |
Contributor
There was a problem hiding this comment.
Just to make things a bit clearer, could this be renamed to something like instance_type_condition?
Contributor
I'm seeing the |
Contributor
Author
lgarber-akamai
approved these changes
Apr 16, 2024
lgarber-akamai
left a comment
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
All tests are passing on my end, excellent work!
yec-akamai
approved these changes
Apr 16, 2024
yec-akamai
left a comment
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Great work! All tests are passing now 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Addressing some failures on TOD due to timeouts and behavior changes
Failures in TOD: http://198.19.5.79:1212/builds/6614a12400a8200001706548?team=DX&buildName=linode_api4&bld_id=6614a12400a8200001706548&testcaseStatus=failure
✔️ How to Test
make testint- should be all passing locally📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.