new: Annotate set/unordered fields as unordered - #390
Merged
Conversation
lgarber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
April 5, 2024 16:55
zliang-akamai
self-requested a review
April 8, 2024 19:06
zliang-akamai
approved these changes
Apr 9, 2024
zliang-akamai
left a comment
zliang-akamai
left a comment
Member
There was a problem hiding this comment.
Works on my end, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds a new
unorderedproperty attribute and annotates unordered properties accordingly. To keep the scope of this PR reasonable, derived/slug properties are intentionally NOT annotated as unordered.NOTE: This PR does not introduce any new encoding/decoding logic; these annotations are expected to be consumed by update logic in downstream projects (e.g. ansible_linode)
I'm sure I missed some unordered properties so please let me know if you discover any 🙂
✔️ How to Test
N/A