Skip to content

new: Add site_type to Region - #386

Merged
yec-akamai merged 2 commits into
devfrom
TPT-2768/add-site-type
Apr 1, 2024
Merged

new: Add site_type to Region#386
yec-akamai merged 2 commits into
devfrom
TPT-2768/add-site-type

Conversation

@yec-akamai

@yec-akamai yec-akamai commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

📝 Description

Expose a new field site_type to Region.

✔️ How to Test

tox
make TEST_CASE=test_get_regions testint

Manual Test:

  1. In a sandbox environment, run the following:
import os

from linode_api4 import LinodeClient

client = LinodeClient(os.getenv("LINODE_TOKEN"))

regions = client.regions()

if len(regions) > 0:
    print(f"Region {regions[0].id} site type: {regions[0].site_type}")
  1. Observe that region site type is in the output.

@yec-akamai
yec-akamai requested a review from a team as a code owner March 26, 2024 20:07
@yec-akamai
yec-akamai requested review from ykim-akamai and zliang-akamai and removed request for a team March 26, 2024 20:07
zliang-akamai
zliang-akamai approved these changes Mar 28, 2024
View reviewed changes

@zliang-akamai zliang-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and looks good to me!

@jriddle-linode jriddle-linode added the enhancement issues that request a enhancement label Mar 28, 2024
lgarber-akamai
lgarber-akamai approved these changes Apr 1, 2024
View reviewed changes

@lgarber-akamai lgarber-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yec-akamai
yec-akamai merged commit 0951c34 into dev Apr 1, 2024
@yec-akamai
yec-akamai deleted the TPT-2768/add-site-type branch April 1, 2024 13:52
@jriddle-linode jriddle-linode added improvement for improvements in existing functionality in the changelog. and removed enhancement issues that request a enhancement labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes
@zliang-akamai zliang-akamai zliang-akamai approved these changes
@ykim-akamai ykim-akamai Awaiting requested review from ykim-akamai ykim-akamai is a code owner automatically assigned from linode/dx

Assignees

No one assigned

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yec-akamai @lgarber-akamai @zliang-akamai @jriddle-linode