new: Add handling for failed events in EventPoller(...).wait_for_next_event_finished(...) - #384
Merged
Merged
Conversation
lgarber-akamai
requested review from
yec-akamai and
ykim-akamai
and removed request for
a team
March 14, 2024 18:22
lgarber-akamai
commented
Mar 14, 2024
| assert result.status == "finished" | ||
|
|
||
| @httpretty.activate | ||
| def test_wait_for_event_finished_failed( |
Contributor
Author
There was a problem hiding this comment.
I opted not to implement an integration test for this change because we generally shouldn't rely on runtime errors.
yec-akamai
approved these changes
Mar 18, 2024
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Works well on my end!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds support for handling events in the failed status when polling using the
EventPoller(...).wait_for_next_event_finished(...)method. When an event enters thefailedstatus, anEventErrorwill not be raised. Previously a failed event would cause the method to poll indefinitely.✔️ How to Test
The following test steps assume you have pulled down this change locally and run
make install.Unit Testing
Manual Testing
linode_api4-pythonsandbox environment (e.g. dx-devenv), run the following: