new: Add vpc field to Instance(...).ips property method result - #379
Merged
lgarber-akamai merged 3 commits intoMar 18, 2024
Merged
Conversation
lgarber-akamai
marked this pull request as ready for review
March 12, 2024 14:56
lgarber-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
March 12, 2024 14:56
yec-akamai
approved these changes
Mar 13, 2024
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Tests passed successfully
lgarber-akamai
commented
Mar 18, 2024
Comment on lines
+133
to
+135
| nat_1_1: Optional[str] = None | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Do we think it'd make sense to implement property methods here to allow for easy access to the corresponding VPC, VPCSubnet, etc. objects from this class? The only issue is that a client isn't embedded in JSON objects as of now, although it would be a relatively straightforward change to make.
edit: Just created an internal feedback entry for this 👍
zliang-akamai
approved these changes
Mar 18, 2024
zliang-akamai
left a comment
Member
There was a problem hiding this comment.
Works well on my end. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds support for the
vpcstructure in theInstance(...).ips(networking information list) property method. Entries in this struct are stored as objects of the newVPCIPAddressclass, which is necessary to expose certain VPC-specific fields and to prevent attempted refreshes on VPC IP addresses.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Integration Testing
Manual Testing