Skip to content

Check None for interfaces parameter of instance_create - #375

Merged
zliang-akamai merged 1 commit into
devfrom
zhiwei/fix-interfaces
Mar 6, 2024
Merged

Check None for interfaces parameter of instance_create#375
zliang-akamai merged 1 commit into
devfrom
zhiwei/fix-interfaces

Conversation

@zliang-akamai

@zliang-akamai zliang-akamai commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

📝 Description

This is to fix an issue that it tried to iterate on interfaces when it's a NoneType.

✔️ How to Test

new_linode, _ = client.linode.instance_create(
    ltype="g6-nanode-1",
    region="us-mia",
    image="linode/ubuntu22.04",
    label="my-ubuntu-linode-test-py"
)

@zliang-akamai
zliang-akamai requested a review from a team as a code owner March 6, 2024 19:43
@zliang-akamai
zliang-akamai requested review from lgarber-akamai, yec-akamai and ykim-akamai and removed request for a team March 6, 2024 19:43
lgarber-akamai
lgarber-akamai reviewed Mar 6, 2024
View reviewed changes
Comment thread linode_api4/groups/linode.py Outdated
@zliang-akamai
zliang-akamai force-pushed the zhiwei/fix-interfaces branch from 77b64f0 to 7b78d0c Compare March 6, 2024 19:59
jriddle-linode
jriddle-linode approved these changes Mar 6, 2024
View reviewed changes

@jriddle-linode jriddle-linode left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally. Nice work.

@zliang-akamai
zliang-akamai merged commit ce9eb0d into dev Mar 6, 2024
@zliang-akamai
zliang-akamai deleted the zhiwei/fix-interfaces branch March 6, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes
@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes
@ykim-akamai ykim-akamai Awaiting requested review from ykim-akamai ykim-akamai is a code owner automatically assigned from linode/dx
@yec-akamai yec-akamai Awaiting requested review from yec-akamai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zliang-akamai @jriddle-linode @lgarber-akamai