Skip to content

Appying PEP 621: storing metadata in pyproject.toml - #315

Merged
zliang-akamai merged 12 commits into
devfrom
zhiwei/pep621
Feb 13, 2024
Merged

Appying PEP 621: storing metadata in pyproject.toml#315
zliang-akamai merged 12 commits into
devfrom
zhiwei/pep621

Conversation

@zliang-akamai

@zliang-akamai zliang-akamai commented Aug 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

The setuptools support is still in beta phase. Hope we can adopt this by the end of this year.

Testing

  • You can do make create-version to verify the version file is created correctly.
  • After creating the version,make dev-install to verify all dependencies and dev dependencies are installed.
  • Write any code to verify the SDK is working.

For example:

from linode_api4 import LinodeClient, Instance

client = LinodeClient("MY_PERSONAL_ACCESS_TOKEN")

new_linode, root_pass = client.linode.instance_create(
    ltype="g6-nanode-1",
    region="us-mia",
    image="linode/ubuntu22.04",
    label="my-ubuntu-linode"
)

new_linode.delete()

@zliang-akamai zliang-akamai changed the title PEP 621 Appying PEP 621: storing metadata in pyproject.toml Aug 14, 2023
@zliang-akamai
zliang-akamai marked this pull request as ready for review August 14, 2023 18:04
@zliang-akamai
zliang-akamai requested a review from a team as a code owner August 14, 2023 18:04
@zliang-akamai
zliang-akamai marked this pull request as draft August 15, 2023 07:04
@lgarber-akamai
lgarber-akamai removed the request for review from a team October 18, 2023 14:14
@zliang-akamai
zliang-akamai force-pushed the zhiwei/pep621 branch 2 times, most recently from 6834657 to 6a59c07 Compare January 30, 2024 22:24
@zliang-akamai
zliang-akamai marked this pull request as ready for review January 31, 2024 02:41
@zliang-akamai
zliang-akamai requested review from a team, yec-akamai and ykim-akamai and removed request for a team January 31, 2024 02:41
lgarber-akamai
lgarber-akamai reviewed Feb 12, 2024
View reviewed changes
Comment thread pyproject.toml
lgarber-akamai
lgarber-akamai reviewed Feb 12, 2024
View reviewed changes
Comment thread pyproject.toml Outdated
lgarber-akamai
lgarber-akamai reviewed Feb 12, 2024
View reviewed changes
Comment thread Makefile Outdated
lgarber-akamai
lgarber-akamai approved these changes Feb 12, 2024
View reviewed changes

@lgarber-akamai lgarber-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than the feedback left above!

I was able to build/install the package and verified that all artifacts are as expected using the following:

Using dev version:

make install

Using explicit version:

make LINODE_SDK_VERSION=v12.34.56 install

lgarber-akamai
lgarber-akamai reviewed Feb 12, 2024
View reviewed changes
Comment thread Makefile
zliang-akamai and others added 3 commits February 12, 2024 12:01
@zliang-akamai
zliang-akamai force-pushed the zhiwei/pep621 branch 2 times, most recently from 765da21 to ca84493 Compare February 13, 2024 01:28
ykim-akamai
ykim-akamai approved these changes Feb 13, 2024
View reviewed changes

@ykim-akamai ykim-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Verified the install steps locally

@zliang-akamai
zliang-akamai merged commit 0bbd8cc into dev Feb 13, 2024
@zliang-akamai
zliang-akamai deleted the zhiwei/pep621 branch February 13, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes
@ykim-akamai ykim-akamai ykim-akamai approved these changes
@yec-akamai yec-akamai Awaiting requested review from yec-akamai yec-akamai is a code owner automatically assigned from linode/dx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zliang-akamai @lgarber-akamai @ykim-akamai @yec-akamai