Expose ip tables package #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Member
Author
|
cc @alpeb |
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
force-pushed
the
zd/non-internal
branch
from
67f303c to
dcb5582
Compare
alpeb
approved these changes
Apr 1, 2024
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple of nits 👍
Comment on lines
170
to
173
| // formatComment is used to format iptables comments in such way that it is possible to identify when the rules were added. | ||
| // This helps debug when iptables has some stale rules from previous runs, something that can happen frequently on minikube. | ||
| func formatComment(text string) string { | ||
| return fmt.Sprintf("proxy-init/%s/%s", text, ExecutionTraceID) | ||
| return fmt.Sprintf("proxy-init/%s", text) |
Member
There was a problem hiding this comment.
Now that the timestamp is not included, this function comment should be amended to not make mention of "when the rules were added".
pkg/iptables/iptables.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // CleanupFirewallConfig removed the iptables rules that have been added as a result of |
Member
There was a problem hiding this comment.
Suggested change
| // CleanupFirewallConfig removed the iptables rules that have been added as a result of | |
| // CleanupFirewallConfig removes the iptables rules that have been added as a result of |
zaharidichev
added a commit
that referenced
this pull request
Jun 6, 2024
- enable the use iptables as a library - adda functionality to remove already configured rules. Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable the use iptables as a library, this change moves it our of the internal package. Additionally, this PR adds functionality to remove already configured iptables.