-
Notifications
You must be signed in to change notification settings - Fork 284
fix: proxy-init and policy-container images have been removed #4333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
| # Use an arbitrary ~recent edge release image to get the proxy | ||
| # identity-initializing and linkerd-await wrappers. | ||
| ARG LINKERD2_IMAGE=ghcr.io/linkerd/proxy:edge-23.11.2 | ||
| ARG LINKERD2_IMAGE=ghcr.io/linkerd/proxy:edge-25.11.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would pointing this at :latest be even better? this drifted more than two years out of date. luckily there was only one other breaking change to spot and fix, but i'd like for this repo to not get so far out of step with the linkerd2 repo again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to latest would at least give us signal that something broke, but it would be tricky to debug and would break CI without a source PR to trace it back to.
We've run into this kind of problem enough that it makes me think we should set up something like Renovate that can do custom dependency updates like these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to leave this as a pinned version for now while we sort out better custom dependency management for cases like these
in linkerd/linkerd2#14577, we combined the proxy and proxy-init image. in linkerd/linkerd2#14348, we removed the policy-controller image. this branch aims to address these breaking changes, and restore CI builds in this repository.
besides just combining images, #14577 included some breaking changes to the helm charts, specifically in how we configure the control plane. this has affected us, because we do not use the production-oriented
ghcr.io/linkerd/proxyimage when running thelinkerd-installtest, or running a local cluster via the commands provided in thejustfile.we use a development-oriented image provided here so that we can attach a shell to the proxy container during development, and run various networking utilities to e.g. diagnose bugs.
this caused us some problems because #14577 removed the helm configuration surface used to configure an image for the proxy-init container. thus, pods would run the development image from the proxy repo, rather than the
'ghcr.io/linkerd/proxy'image that i've attempted to specify in the justfile.if i understand correctly, there are two ways to remediate this: (1) copy the same changes involving
setcapcommands over to that development dockerfile (i also found that this required setting the user torootfor things to work), or (2) revert parts of #14577 and reintroduce these settings to the control plane chart, instead defaulting to thecr.l5d.io/linkerd/proxyimage.my understanding is that (2) would be unfortunate because we are actively trying to get away from having to maintain too much init-related configuration surface, as it introduces a significant maintenance burden in the control plane.
this branch updates the no-longer-recent edge release used in our development image, and then updates the images used in our justfile.
changes from linkerd/linkerd2#14577 are additionally introduced here, so that the proxy image also functions as a workable init container image.