Skip to content

Commit 208b6b9

Browse files
committed
chore(tracing): Use upstream tracing batch exporter
The proxy used its own custom trace exporter for some time. It was built before the upstream OpenTelemetry libraries were available, and they have outlived their usefulness. This replaces the custom exporter with a batch exporter configured to export to the same endpoint with the same service configuration. In the future, this exporter can be installed as a global default trace processor, which would decouple it from the service layer where the proxy generates spans for requests. Signed-off-by: Scott Fleener <scott@buoyant.io>
1 parent 2708010 commit 208b6b9

File tree

1 file changed

+2
-0
lines changed
  • linkerd/opentelemetry/src

1 file changed

+2
-0
lines changed

linkerd/opentelemetry/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ fn convert_span(span: ExportSpan) -> Result<SpanData, Error> {
185185
mod tests {
186186
use super::*;
187187
use linkerd_trace_context::{export::SpanKind, Id, Span};
188+
use opentelemetry_proto::tonic::common::v1::any_value::Value::StringValue;
189+
use opentelemetry_proto::tonic::common::v1::AnyValue;
188190
use opentelemetry_proto::tonic::common::v1::InstrumentationScope;
189191
use std::{collections::HashMap, sync::Arc, time::SystemTime};
190192
use tokio::sync::mpsc;

0 commit comments

Comments
 (0)