Skip to content

Commit 0b165b6

Browse files
committed
nit(http/prom): nitpick a todo comment
Signed-off-by: katelyn martin <kate@buoyant.io>
1 parent 632d9f9 commit 0b165b6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

linkerd/http/prom/src/status.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,13 +258,14 @@ where
258258
L: Clone + Hash + Eq + Send + Sync + 'static,
259259
{
260260
fn on_eos(eos: EosRef<'_, Error>, mut stream_label: SL, metrics: StatusMetrics<L>) {
261-
let ugh = RequestCancelled.into(); // XXX(kate)
261+
// TODO(kate): a static cancellation error. see linkerd/linkerd2-proxy#4306.
262+
let cancelled = RequestCancelled.into();
262263

263264
stream_label.end_response(match eos {
264265
EosRef::None => Ok(None),
265266
EosRef::Trailers(trls) => Ok(Some(trls)),
266267
EosRef::Error(error) => Err(error),
267-
EosRef::Cancelled => Err(&ugh),
268+
EosRef::Cancelled => Err(&cancelled),
268269
});
269270

270271
let labels = stream_label.status_labels();

0 commit comments

Comments
 (0)