Repository navigation
fix(import): list every team project when selecting an import project - #1291
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The --project flag and the project prompts read only the first page of team projects, so projects beyond the first 50 were reported as not found. Paginate through all projects.
🦋 Changeset detectedLatest commit: 725d326 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
linear-import --projectreporting "Project not found" for projects beyond the first page of results.importIssuesread team projects with a singleteam.projects()call, which returns 50 projects by default. For teams with more projects, the--projectflag and the interactive project prompts could not see the rest. Teams, users and labels already usepaginate; this change does the same for projects through a smallfetchTeamProjectshelper used in all three places.Testing
The new test runs
importIssuesagainst a stubbed API where the requested project is on the second page of team projects, and checks that the issue is created in that project.process.exit(1)after the project is not found).The full
@linear/importtest run passes, and a changeset is included.