fix(sanity): live preview service is called before be initialized#9
Merged
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit b6059d9.
☁️ Nx Cloud last updated this comment at |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the new behavior?
This PR fixes a timing issue with the LivePreviewService initialization. Previously, the service was initialized using
afterNextRender(), which could potentially cause race conditions or initialization delays. The change replaces this with Angular'seffect(), ensuring that:Does this PR introduce a breaking change?
Other information
The change from
afterNextRendertoeffectis a more idiomatic way to handle reactive initialization in Angular's signals-based architecture. This ensures better predictability of when the live preview service is initialized and maintains reactivity with the token input.What gif best describes this PR or how it makes you feel?
[A "Perfect Timing" gif would be appropriate here since this PR fixes a timing-related issue]
