Skip to content

fix(e2e): let Playwright own Studio servers#40

Merged
osnoser1 merged 1 commit into
mainfrom
osnoser1/fix-playwright-e2e-server-teardown
Jun 8, 2026
Merged

fix(e2e): let Playwright own Studio servers#40
osnoser1 merged 1 commit into
mainfrom
osnoser1/fix-playwright-e2e-server-teardown

Conversation

@osnoser1

@osnoser1 osnoser1 commented Jun 8, 2026

Copy link
Copy Markdown
Member

PR Checklist

No linked issue.

What is the new behavior?

Playwright now starts the Sanity Presentation E2E preview and Studio servers directly with package-local pnpm --dir ... exec ... commands, passing server-specific values through Playwright's structured env option. This removes the nested turbo run serve persistent-task layer from Playwright's webServer lifecycle so Playwright can tear down the servers it starts.

The CI workflow no longer manually kills ports 4200 and 3333 between Presentation E2E runs because the servers are now owned and cleaned up by Playwright.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Validated with:

pnpm turbo run lint --filter=sanity-presentation-e2e
pnpm --dir apps/sanity-presentation-e2e exec playwright test --config playwright.config.ts --list
SANITY_E2E_CDP_ENDPOINT= SANITY_E2E_BROWSER_CHANNEL= pnpm turbo run e2e-studio --filter=sanity-presentation-e2e

After the hermetic Studio E2E run finished, ports 4200 and 3333 were no longer listening.

[Optional] What gif best describes this PR or how it makes you feel?

@osnoser1 osnoser1 marked this pull request as ready for review June 8, 2026 17:10
@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for limitless-angular-sanity-example canceled.

Name Link
🔨 Latest commit 86c59a9
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a26f49db9a000000844e8d9

@osnoser1 osnoser1 merged commit 19e0b01 into main Jun 8, 2026
14 checks passed
@osnoser1 osnoser1 deleted the osnoser1/fix-playwright-e2e-server-teardown branch June 8, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant