feat(sanity): sanity image transformations#2
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 88eb546. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Feature
This PR introduces real-time image transformation updates during Sanity live editing sessions, enabling immediate preview of image crop adjustments and other transformations without requiring page reload.
Technical Implementation
1. Manual Change Detection for Live Updates
The core improvement is in the
SanityImagedirective, which now properly handles live updates to image sources.2. Enhanced URL Parameter Handling
Improved the image loader to handle URL parameters directly:
3. Type-Safe Image Parameters
Benefits
Breaking Changes
None. This is a feature enhancement that maintains backward compatibility.
This PR template focuses on the most significant aspect - the live editing functionality - while still covering the other important technical improvements. The manual change detection implementation is crucial as it enables real-time preview of image transformations, which is especially valuable during content editing sessions in Sanity Studio.
Closes #1