Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
 |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
luvs01
changed the base branch from
dev
to
codex/catalog-heal-hardlink-path-20261023
October 24, 2026 16:01
luvs01
marked this pull request as ready for review
October 24, 2026 20:02
…88-refresh-parent-cf72-20261025
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
OPENCODEX_HOMEpoints to a regular file, an account-store read can start optional directory hardening before a later profile check rejects the path. Check that the target is a directory before starting chmod or an ACL task. Keep directory symlinks/junctions supported, preserve the real-home guard, and leave required write-path validation unchanged.Drain the two account suites' configuration-hardening work before removing their fixtures, using the original fixture directory even when a case changes
OPENCODEX_HOME. Assertions, timeouts and the shared teardown helper's ordering remain unchanged.Head
d06cf9b3d5b55fc8dd024dc2854e5d0b778d2bd4normally merges the current #7610 parentcf72010f480d607bdf390717c28f62be240b0981into previous childa554968b. All five child-specific blobs are byte-identical to that child; the parent refresh does not change this guard or its callers. Retarget todevafter the parent lands.Verification
On this merged head, official Windows Bun 1.4.4, using the existing CI timeout contract:
codex-account-slot-identity,codex-auth-headless-accountsandwindows-config-read-acl-memo: 33 passed / 1 skipped / 0 failed. The inaccessible-default-home case explicitly excludes Windows; it is not counted as passing.The unchanged child at
a554968bpreviously passed full cross-platform run 40109666635, attempt 2: 28 successful jobs / 6 conditional skips. That is historical evidence fora554968b, not a new-head full run. Earlier cancellations/timeouts and the older macOS hardlink failure are retained separately; this guard is not claimed to explain or repair them. #7610 owns the related catalog path-identity change.Exact-head automatic CI 40227402907 passed. The regular-file guard does not solve concurrent path-replacement races or establish broad native permission guarantees. Merge order remains parent-first. No live runtime, account, certificate or GUI changed.
Checklist