Skip to content

CVE-2026-5917: Escape repo path in gen_proto() - #7347

Merged
ethomson merged 1 commit into
libgit2:mainfrom
sgallagher:cve_2026_5917
Aug 13, 2026
Merged

CVE-2026-5917: Escape repo path in gen_proto()#7347
ethomson merged 1 commit into
libgit2:mainfrom
sgallagher:cve_2026_5917

Conversation

@sgallagher

Copy link
Copy Markdown
Contributor

Takes inspiration from 346f28b

Signed-off-by: Stephen Gallagher sgallagh@redhat.com

Takes inspiration from 346f28b

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
@ethomson

Copy link
Copy Markdown
Member

Welp. Yes, this is true. We are going through responsible disclosure for this bug. Or, we were! I guess this has now been disclosed. And you've assigned yourself a CVE for it.

Let's coordinate better in the future, please?

@ethomson ethomson closed this Aug 13, 2026
@sgallagher

Copy link
Copy Markdown
Contributor Author

https://access.redhat.com/security/cve/cve-2026-5917 indicates that it was publicly disclosed on Aug. 11th. Since I didn't see a fix ready, I assumed it had blindsided you and tried to get you a fix ASAP.

@ethomson

Copy link
Copy Markdown
Member

Thanks - my many apologies: I misunderstood, and it is not you with whom I should be grouchy. I am preparing some patch releases tonight since we had this in the queue, but it was batched with other security fixes. Once that's done, I will figure out what's happened here.

@sgallagher

Copy link
Copy Markdown
Contributor Author

Not a problem. And you're correct: I should have reached out before publishing the PR. I wasn't thinking. I'll do better next time.

@ethomson

Copy link
Copy Markdown
Member

Not sure that I agree. It was already public, and you were acting proactively to keep people safe and secure. You were effectively mitigating a zero day (or in fact a -2 day). Thank you for that, and again, apologies for the snap reaction. I was busy with something else and didn't give this the attention that it deserved.

My mistake, thank you, and apologies again.

@ethomson ethomson reopened this Aug 13, 2026
@ethomson
ethomson merged commit 0b87f30 into libgit2:main Aug 13, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants