config: refactor freeing config list after getting entry - #7235
Open
kcsaul wants to merge 1 commit into
Open
Conversation
kcsaul
marked this pull request as draft
April 30, 2026 10:23
kcsaul
force-pushed
the
fix/config-memory-backend-followup
branch
from
April 30, 2026 11:03
a2bcb0e to
e868e27
Compare
kcsaul
force-pushed
the
fix/config-memory-backend-followup
branch
from
April 30, 2026 11:10
e868e27 to
0043156
Compare
kcsaul
marked this pull request as ready for review
April 30, 2026 11:30
Contributor
Author
|
@ethomson - Here's the follow-up, still feels a little messy to me, but possibly a step in the right direction to improve the boundary between backend implementations and config list being reused, and hopefully in keeping with a more holistic solution you were after. |
Contributor
Author
|
@ethomson - spotted a few config related issues being raised recently, one about making dependencies of git_config_list public, so may be worth getting this merged. Following that, could consider what would be needed to make git_config_list itself public so it can be reused directly by custom backends, which may depend on revising how entries are added to ensure they use expected free function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7232, this is intended to provide a more holistic fix, with config backends being refactored to support
git_config_list_getandgit_config_list_get_uniquecallinggit_config_list_increfbefore returning an entry, rather than it needing to be handled externally.However, this still relies on assumption backends using
git_config_listwill create entries usinggit_config_list_entry_freefor clean-up before appending to the list.