cmake: fix creation of static lib in xcode#7139
Open
dyfer wants to merge 1 commit intolibgit2:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was trying to use libgit2 as a submodule building static library for another project under Xcode 16.1, I got linker errors and realized that the static library was not being created. In the process I found that - as far as I can tell - Xcode needs a workaround (a dummy C file) in order to actually create a static library file.
Libgit used to have this workaround built-in, but it was removed in d7b49ed (#6133).
As far as I can tell, this workaround is still needed when one wants to create a static library under Xcode.
For reference, this is what I used to build a static library: