fix: git_remote_download assumes oid capability#7123
Open
DanConwayDev wants to merge 1 commit intolibgit2:mainfrom
Open
fix: git_remote_download assumes oid capability#7123DanConwayDev wants to merge 1 commit intolibgit2:mainfrom
git_remote_download assumes oid capability#7123DanConwayDev wants to merge 1 commit intolibgit2:mainfrom
Conversation
Stop throwing error when requesting oids from a git server that doesn't explicitly advertise that capability. The overwhelming majority of git servers will serve this request even when they don't advertise this capability, e.g. git-http-backend. For many years, the git reference implementation has assumed servers have this capability even when `allow-tip-sha1-in-want` or `allow-reachable-sha1-in-want` isnt included in `git-upload-pack-advertisement`, e.g. with `git fetch <remote> <oid>`. closes libgit2#7078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop throwing error when requesting oids from a git server that doesn't explicitly advertise that capability.
The overwhelming majority of git servers will serve this request even when they don't advertise this capability, e.g. git-http-backend.
For many years, the git reference implementation has assumed servers have this capability even when
allow-tip-sha1-in-wantorallow-reachable-sha1-in-wantisnt included ingit-upload-pack-advertisement, e.g. withgit fetch <remote> <oid>.closes #7078