cmake: disable warnings for operands with different enum types#7114
Merged
pks-t merged 1 commit intolibgit2:mainfrom Aug 4, 2025
Merged
cmake: disable warnings for operands with different enum types#7114pks-t merged 1 commit intolibgit2:mainfrom
pks-t merged 1 commit intolibgit2:mainfrom
Conversation
With a recent upgrade to a newer version of MSVC we now get a bunch of warnings when two operands use different enum types. While sensible in theory, in practice we have a couple of non-public enums that extend public enums, like for example with `GIT_SUBMODULE_STATUS`. Let's for now disable this warning to unblock our builds. The alternative would be to add casts all over the place, but that feels rather cumbersome.
pks-gitlab
force-pushed
the
pks-msvc-different-enum-warnings
branch
from
1dd1fc5 to
5d78d63
Compare
Closed
pks-t
approved these changes
Aug 4, 2025
Member
pks-t
left a comment
pks-t
left a comment
There was a problem hiding this comment.
I'm going to merge this for now to unblock CI pipelines. We can find a more sustainable solution going forward at a later point, if we want to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a recent upgrade to a newer version of MSVC we now get a bunch of warnings when two operands use different enum types. While sensible in theory, in practice we have a couple of non-public enums that extend public enums, like for example with
GIT_SUBMODULE_STATUS.Let's for now disable this warning to unblock our builds. The alternative would be to add casts all over the place, but that feels rather cumbersome.