Skip to content

docs: correct wrong docstring info for git_remote_url#7076

Merged
ethomson merged 1 commit into
libgit2:mainfrom
dmnq-f:docfix-remote-url
Jun 4, 2025
Merged

docs: correct wrong docstring info for git_remote_url#7076
ethomson merged 1 commit into
libgit2:mainfrom
dmnq-f:docfix-remote-url

Conversation

@dmnq-f
Copy link
Copy Markdown
Contributor

@dmnq-f dmnq-f commented May 16, 2025

The docstring for git_remote_url incorrectly states that this function will return the push URL if it was configured. This is wrong, as it does not (and should not, but git_remote_pushurl does - this is probably an oversight from copy/pasting the docstring from the latter function).

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
@ethomson
Copy link
Copy Markdown
Member

ethomson commented Jun 4, 2025

Good catch; thanks for the fix!

@ethomson ethomson merged commit c232aec into libgit2:main Jun 4, 2025
@dmnq-f dmnq-f deleted the docfix-remote-url branch June 5, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants