Skip to content

Do not return free'd git_repository object on error #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pks-t merged 1 commit into from
Jan 17, 2020
Merged

Do not return free'd git_repository object on error #5361

pks-t merged 1 commit into from
Jan 17, 2020

Conversation

@csware
Copy link
Contributor

@csware csware commented Jan 16, 2020

Regression introduced in commit dde6d9c.

This issue causes lots of crashes in TortoiseGit.

@csware
Do not return free'd git_repository object on error
470a05d 
Regression introduced in commit dde6d9c.

This issue causes lots of crashes in TortoiseGit.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@ethomson
Copy link
Member

ethomson commented Jan 16, 2020

LGTM. Going to hold this open for a bit longer for additional feedback.

@pks-t pks-t merged commit 1908884 into libgit2:master Jan 17, 2020
@pks-t
Copy link
Member

pks-t commented Jan 17, 2020

Thanks a lot for your fix, @csware!

@csware csware deleted the no-return-freed_object branch January 17, 2020 12:37
@implausible implausible mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethomson ethomson ethomson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csware @ethomson @pks-t