Skip to content

Conversation

@tiennou
Copy link
Contributor

@tiennou tiennou commented Dec 13, 2017

Depends on #4445. Sadly I can't open the PR against libgit2 and set that as the base branch, so do note that the first commit: commits come from that other PR.

This adds graft support to git_repository as a private API. The end goal is to be able to store and obey shallow roots when working with a shallow repository, but this is usable on its own.

As discussed on #4331, this is unrelated to the git-replace mechanism.

@tiennou tiennou mentioned this pull request Dec 13, 2017
@tiennou tiennou force-pushed the shallow/graft-support branch from 92a8520 to 809c741 Compare December 15, 2017 22:59
@tiennou tiennou force-pushed the shallow/graft-support branch 2 times, most recently from 1bce177 to 5cb836d Compare February 6, 2018 23:15
@tiennou tiennou force-pushed the shallow/graft-support branch from 5cb836d to 82ea81b Compare April 22, 2018 13:32
@tiennou tiennou force-pushed the shallow/graft-support branch from 82ea81b to 1ee62c2 Compare July 1, 2018 10:28
@tiennou tiennou force-pushed the shallow/graft-support branch 2 times, most recently from ff61689 to 40dc979 Compare August 2, 2018 19:38
@tiennou tiennou force-pushed the shallow/graft-support branch 3 times, most recently from 7c78d5b to 00fd43c Compare October 25, 2018 21:44
This allows us to pick which data from a commit we're interested in. This will be used by the revwalk code, which is only interested in parents' and committer data.
This represents (old-style) grafted commits, a.k.a an array of overridden parents for a commit's OID.
This wires git_repository to open the .git/info/grafts file and load its contents as git_commit_grafts objects.
@tiennou tiennou force-pushed the shallow/graft-support branch from 00fd43c to 6f58306 Compare February 3, 2019 09:22
@pks-t
Copy link
Member

pks-t commented Sep 27, 2019

I don't think it's necessary to have this PR reviewed separately from #4331. #4331 doesn't add much on top of the grafts API, only some small bits of plumbing to wire it all up. I'm thus closing this PR for now in favour of #4331, which I'd like to land directly. @tiennou: if you disagree, please let me know and I'll immediately reopen this.

@pks-t pks-t closed this Sep 27, 2019
@tiennou tiennou deleted the shallow/graft-support branch September 29, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants