Merge push in remote #2516
Closed
Merge push in remote #2516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git_revspec_parse returns empty strings instead of NULLs, so "delete" refspecs would try to have "" resolved and fail.
Maybe the names of `git_transfer_progress_cb` should be made clearer though.
Contributor
Author
|
Travis still hates me 😢. I'm suspecting state is being shared in those tests, like b1 gets pushed, the test pass, then you push b2 and the test finds both b1 and b2 and thus fails. I'm pretty sure the other |
Member
|
Yes, the push tests do leave some state behind. IIRC most of the push tests make sure initially that they clean up whatever is in the repository. |
Member
|
Superseded by #2608 . The push state was definitely quite fiddly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rebased #2221, because it was based on
development.