fix nested class property defaults loading #7718
Open
+84
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyettinger
previously approved these changes
Oct 31, 2025
|
Good input. I think it should work because the type should be string instead of class but I will add another object to the properties test map to validate it and to not break it in the future ;) |
|
I should have some free time this weekend. I'll give this a quick once over and a test, then report back any findings. |
tommyettinger
approved these changes
Nov 2, 2025
|
Had a moment to finally take a look. This seems pretty solid, as well as the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #7717.
@BoBIsHere86 please play around with it as well whenever you have time.
The problem was with nested classes. My example was assigning a "project class" that has a class property itself to a tile but not specifying any of the values of the class property.
We then got an empty Json object in
loadMapPropertiesClassDefaultsand theclassMember.defaultValue.asString()then failed.The comment that class properties were already loaded before was wrong. It is true for flat class properties but it is not the case for nested classes (or at least not in that specific scenario).
We now handle this case with the
"class".equals(classMember.type)branch. I also enhanced the test and tried it in GWT and worked on my machine. I was also able to reproduce the issue of my project with this test initially.The new test object looks like this (Class is assigned to a project class called "testClassNested" which has another class property called "classClass"):
I also played around with it some more by adding more nesting and overriding certain values on different levels. For me it looked fine but would be great if someone else also plays around a little bit with it.
Iirc this method and the problem was introduced by me. Sorry for that! :(