scene2d native input integration #7671
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TextField changes look good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #7670.
The commit to review is 4f75a18.
I'm opening this as a draft for initial feedback.
This PR elevates the new API introduced in #7004 to make it easily accessible for use in scene2d.
This PR adds new fields to
TextField, to make use of all features provided by the new API. SpecificallyautocompleteOptions,keyboardTypeandpreventAutoCorrection.The API supports placeholder, the
messageTextwas used for that now.The
OnscreenKeyboardmethod was splitted in two (close/show). This is not strictly necessary, but imo leads to a cleaner API.The default keyboard used can be toggled globally via
TextField#DEFAULT_ONSCREEN_KEYBOARD. Note, thatInput#setOnscreenKeyboardVisibleandInput#openTextInputFieldare mutually exclusive and should not be used together.@NathanSweet fyi, because it is scene2d