Skip to content

Conversation

@williamdes
Copy link

Let me know if it needs to be split up as a separate variant ?

@dclong
Copy link
Collaborator

dclong commented Dec 28, 2022

@williamdes,

Would you create a PR into the alpine branch instead of the dev branch? The main/dev (corresponding to latest/next Docker image tags) branches of my Docker images are all based on Ubuntu and are mainly for interactive use cases (especially with JupyterHub). User friendliness is the main concern but size, speed and even security are of less concerns. My Docker images based on other Linux distributions are maintained in other branches such as debian, centos7, etc. Alpine is a good one to have for deploying production services for its size, load speed and security.

@williamdes williamdes changed the base branch from dev to alpine December 29, 2022 14:16
@williamdes williamdes requested a review from dclong December 29, 2022 14:23
@williamdes
Copy link
Author

It should be okay now, on what branch should README changes be done ?
I added a build workflow: https://github.com/williamdes/docker-rustpython/actions/runs/3801158714/jobs/6465327618

Copy link
Collaborator

@dclong dclong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me except 1 minor thing. We do not need the file build.yml. I've explained this in the inline comments.

@williamdes
Copy link
Author

It looks good to me except 1 minor thing. We do not need the file build.yml. I've explained this in the inline comments.

I removed it, thank you for explaining

@williamdes williamdes requested a review from dclong December 29, 2022 18:59
@dclong
Copy link
Collaborator

dclong commented Dec 29, 2022

You had a good question regarding documentation. The "splitting branch" approach for different variants of Docker images has several advantages that I value but it does not handle documentation very well. In general, I try to use the same doc for different branches, and the doc links to https://www.legendu.net/en/blog/my-docker-images/ for more detailed instructions.

I admit that the docs are not very well maintained as there weren't many public users of my Docker images. But let me improve the doc practices.

@dclong dclong merged commit 2bd1642 into legendu-net:alpine Dec 29, 2022
@williamdes williamdes deleted the alpine-variant branch December 30, 2022 04:31
@williamdes
Copy link
Author

You had a good question regarding documentation. The "splitting branch" approach for different variants of Docker images has several advantages that I value but it does not handle documentation very well. In general, I try to use the same doc for different branches, and the doc links to https://www.legendu.net/en/blog/my-docker-images/ for more detailed instructions.

I admit that the docs are not very well maintained as there weren't many public users of my Docker images. But let me improve the doc practices.

Okay, basically I will copy the examples and remove the DOCKER_ ENVs that do not exist with the base image of alpine

The image is built but does not support multiple architectures

Since this list of possible architectures is limited to the image that has the lowest list in the docker image you can probably write a script for it and use docker buildx on your building workstation?

For example if rust supports A B C D
And alpine only B D the result is B D
Example: https://github.com/sudo-bot/docker-phpmyadmin-snapshots/blob/d94dc8445c44d0826dd4de9400bd29c4b1c9f2f3/.github/workflows/publish.yml#L37

williamdes added a commit to sudo-bot/docker-phpldapadmin that referenced this pull request Dec 30, 2022
@williamdes williamdes mentioned this pull request Dec 31, 2022
williamdes added a commit to sudo-bot/docker-rustpython that referenced this pull request Feb 21, 2023

FROM alpine:3.17

RUN apk --no-cache add musl
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like libgcc should be installed too

@williamdes
Copy link
Author

Hi @dclong

I created my own image for the following reasons:

  • The @sudo-bot org has the sponsored OSS grade on Docker Hub, that gives some nice advandages
  • The multi arch build and all build logs are public, no hidden infrastructure
  • I needed a static Docker label
  • I needed multi-arch builds
  • The base image of your image is too complicated for such a simple build process
  • That's what I said I would do: Multi arch builds #10 (comment)

I do not intend to maintain the alpine variant anymore nor use this image. That you so much for welcoming my contributions and making this image available my project most needed it 🚀

I think you can archive this image/repository if you want to: https://github.com/search?q=%22dclong%2Frustpython%22&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants