-
Notifications
You must be signed in to change notification settings - Fork 0
Build an Alpine variant #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would you create a PR into the alpine branch instead of the dev branch? The main/dev (corresponding to latest/next Docker image tags) branches of my Docker images are all based on Ubuntu and are mainly for interactive use cases (especially with JupyterHub). User friendliness is the main concern but size, speed and even security are of less concerns. My Docker images based on other Linux distributions are maintained in other branches such as |
|
It should be okay now, on what branch should README changes be done ? |
dclong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me except 1 minor thing. We do not need the file build.yml. I've explained this in the inline comments.
I removed it, thank you for explaining |
|
You had a good question regarding documentation. The "splitting branch" approach for different variants of Docker images has several advantages that I value but it does not handle documentation very well. In general, I try to use the same doc for different branches, and the doc links to https://www.legendu.net/en/blog/my-docker-images/ for more detailed instructions. I admit that the docs are not very well maintained as there weren't many public users of my Docker images. But let me improve the doc practices. |
Okay, basically I will copy the examples and remove the DOCKER_ ENVs that do not exist with the base image of alpine The image is built but does not support multiple architectures Since this list of possible architectures is limited to the image that has the lowest list in the docker image you can probably write a script for it and use docker buildx on your building workstation? For example if rust supports A B C D |
|
|
||
| FROM alpine:3.17 | ||
|
|
||
| RUN apk --no-cache add musl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like libgcc should be installed too
|
Hi @dclong I created my own image for the following reasons:
I do not intend to maintain the alpine variant anymore nor use this image. That you so much for welcoming my contributions and making this image available my project most needed it 🚀 I think you can archive this image/repository if you want to: https://github.com/search?q=%22dclong%2Frustpython%22&type=code |
Let me know if it needs to be split up as a separate variant ?