Skip to content

Fix tokenizer#383

Merged
leejet merged 1 commit intoleejet:masterfrom
stduhpf:master
Sep 2, 2024
Merged

Fix tokenizer#383
leejet merged 1 commit intoleejet:masterfrom
stduhpf:master

Conversation

@stduhpf
Copy link
Contributor

@stduhpf stduhpf commented Aug 29, 2024

The type char is signed by default, this causes problems with characters having ASCII code greater than 127.

Fixes #382

Copy link
Contributor

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good observation

@leejet
Copy link
Owner

leejet commented Sep 2, 2024

Thank you for your contribution.

@leejet leejet merged commit 14206fd into leejet:master Sep 2, 2024
stduhpf added a commit to stduhpf/stable-diffusion.cpp that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-ASCII characters in prompt crashes the tokenizer

3 participants