Add ays, clip skip and vae, to image embedded params#316
Closed
one-lithe-rune wants to merge 2 commits intoleejet:masterfrom
Closed
Add ays, clip skip and vae, to image embedded params#316one-lithe-rune wants to merge 2 commits intoleejet:masterfrom
one-lithe-rune wants to merge 2 commits intoleejet:masterfrom
Conversation
- If 'ays' is set as the scheduler include it in the 'Sampler' tag in the data embedded into the final image. This makes it the same as how Karras is handled - If a custom VAE path is set, include the vae name (without path and extension) in embedded image params under a `VAE:` tag. - If a custom Clip skip is set, include that Clip skip value in embedded image params under a `Clip skip:` tag.
Contributor
|
Tested it locally; looks good. The exponential and gits schedulers are missing (probably added after this PR...), but they can be easily added in a follow-up commit. |
Owner
|
Thank you for your contribution. The corresponding changes have been merged in 743. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since my own little frontend app reads the embedded parameter info from PNG images to display them ready for editing and generating again, I noticed that the
Samplertag includes 'karras' if you have set that scheduler, but doesn't include 'ays' if you have set that. Since 'ays' has been added recently I'm guessing this is unintentional?Since I was already in there to fix that, I also added
VAEandClip Skipto be written if vae_path or clip_skip have been set, since those are also useful for my app.Changes
VAE:tag.Clip skip:tag.